[Rendering] Parallelize ES requests #199124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
jloleysens
approved these changes
Nov 6, 2024
💚 Build Succeeded
Metrics [docs]
cc @afharo |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 6, 2024
(cherry picked from commit be3c159)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 6, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Rendering] Parallelize ES requests (#199124)](#199124) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T16:09:41Z","message":"[Rendering] Parallelize ES requests (#199124)","sha":"be3c159cfc9915abc48a409e123ee11070d34dba","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","performance","release_note:skip","v9.0.0","backport:prev-minor","Team:Performance"],"title":"[Rendering] Parallelize ES requests","number":199124,"url":"https://github.com/elastic/kibana/pull/199124","mergeCommit":{"message":"[Rendering] Parallelize ES requests (#199124)","sha":"be3c159cfc9915abc48a409e123ee11070d34dba"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199124","number":199124,"mergeCommit":{"message":"[Rendering] Parallelize ES requests (#199124)","sha":"be3c159cfc9915abc48a409e123ee11070d34dba"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <[email protected]>
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
APM traces have shown that these multiple
GET .kibana/_doc/configcan take up to 400ms, leading to a joined sequential time of 1.2s.This code aims to run them concurrently to reduce any latency/network/ES effects when serving the
index.htmlrequests.For maintainers